Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 4616 - no food preferences displayed in onboarding #4618

Closed

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Now we don't display the food preference page during the onboarding.

Screenshot

top bottom
Screenshot_2023-09-03-08-54-23 Screenshot_2023-09-03-08-54-28

Fixes bug(s)

Impacted files

  • preferences_page.dart: no food preferences displayed in onboarding
  • summary_card.dart: minor bug fix where the fast track button was displayed on the onboarding

Impacted files:
* `preferences_page.dart`: no food preferences displayed in onboarding
* `summary_card.dart`: minor bug fix where the fast track button was displayed on the onboarding
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner September 3, 2023 07:02
@github-actions github-actions bot added 🥫 Product page 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… summary card labels Sep 3, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4618 (94039d5) into develop (0a64d60) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #4618   +/-   ##
========================================
  Coverage    10.13%   10.14%           
========================================
  Files          299      299           
  Lines        15692    15688    -4     
========================================
  Hits          1591     1591           
+ Misses       14101    14097    -4     
Files Changed Coverage Δ
...oth_app/lib/pages/onboarding/preferences_page.dart 0.00% <ø> (ø)
...ges/smooth_app/lib/pages/product/summary_card.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@monsieurtanuki monsieurtanuki marked this pull request as draft September 5, 2023 16:46
@monsieurtanuki
Copy link
Contributor Author

Not relevant to maintain as specs are going to change about the onboarding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… PR: needs rebase 🥫 Product page summary card
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable the Food Settings from the Onboarding sequence
2 participants